fix weblab inspector toggle state #14813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bramble could disable the Inspector Mode when an element in the preview frame is clicked. When this happened, our UI was unaware and the inspector toggle UI became out of sync...
brambleHost.js, bind to Bramble'sinspectorChangeevent. Allow weblab to register anonInspectorChanged()callback, like it does foronProjectChanged().WebLab.js, supply anonInspectorChanged()callback that stores the new value in redux. Change theonToggleInspector()function to use the redux state as the source of truth (instead of an instance variable). Remove the explicit call toactions.changeInspectorOn()since that will now come via the callback - whether our UI triggers the change or Bramble's UI triggers the change.