Add missing require #14816
Merged
Add missing require #14816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashercodeorg
reviewed
May 3, 2017
| @@ -1,4 +1,5 @@ | |||
| require_relative 'pegasus_form_errors' | |||
| require 'validates_email_format_of' | |||
There was a problem hiding this comment.
That isn't the filename, is it?
There was a problem hiding this comment.
Ah, never mind, it is a gem.
There was a problem hiding this comment.
Also if I get the filename wrong, then dashboard-server fails to start:
With require 'i_dont_exist':
~ bin/dashboard-server
10:05:06 [rerun] Dashboard launched
10:05:09 [rerun] Watching /Users/andrew/Code/code-dot-org/lib, /Users/andrew/Code/code-dot-org/shared/middleware, /Users/andrew/Code/code-dot-org/pegasus for **/*.{rb,ru,yml} (ignoring **/migrations/*.rb) using Darwin adapter
/Users/andrew/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-5.0.1/lib/active_support/dependencies.rb:293:in `require': cannot load such file -- i_dont_exist (LoadError)
from /Users/andrew/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-5.0.1/lib/active_support/dependencies.rb:293:in `block in require'
from /Users/andrew/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-5.0.1/lib/active_support/dependencies.rb:259:in `load_dependency'
from /Users/andrew/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-5.0.1/lib/active_support/dependencies.rb:293:in `require'
from /Users/andrew/Code/code-dot-org/lib/forms/pegasus_form_validation.rb:2:in `<top (required)>'
...
ashercodeorg
approved these changes
May 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14780 worked in development, but on staging it failed due to a missing require (dependencies are different in dev and other envs).
CC @caleybrock