Add tests for codegen.evalWithEvents #14835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcardune
force-pushed
the
pcardune-codegen-evalWithEvents-tests
branch
from
b2e0753
to
7e0b711
Compare
pcardune
force-pushed
the
pcardune-codegen-evalWith-tests
branch
from
8423763
to
184d6b2
Compare
There were some interesting cases to test in here!
pcardune
force-pushed
the
pcardune-codegen-evalWithEvents-tests
branch
from
7e0b711
to
b154d12
Compare
|
Ok, tests are now passing. This is ready for a review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some interesting cases to test in here!
Depends on #14829