Add route and landing page for Stage Extras v2 #14891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashercodeorg
reviewed
May 5, 2017
| def stage_extras | ||
| authorize! :read, ScriptLevel | ||
|
|
||
| @stage = Script.get_from_cache(params[:script_id]).stages.select {|s| !s.lockable? && s.relative_position == params[:stage_position].to_i}.first |
Bjvanminnen
reviewed
May 8, 2017
| .clear | ||
|
|
||
| %h2= t('continue') | ||
| = link_to t('next_stage'), @stage.script_levels.last.next_level_or_redirect_path_for_user(current_user) |
There was a problem hiding this comment.
any reason not to have the rest of this haml in react as well?
Bjvanminnen
reviewed
May 8, 2017
| export default class StageExtras extends React.Component { | ||
| constructor(props) { | ||
| super(props); | ||
| } |
There was a problem hiding this comment.
constructor is unnecessary if you're not doing anything in it.
Bjvanminnen
reviewed
May 8, 2017
| StageExtras.propTypes = { | ||
| stageNumber: React.PropTypes.number.isRequired, | ||
| nextLevelPath: React.PropTypes.string.isRequired, | ||
| }; |
There was a problem hiding this comment.
You might be able to do this as static propTypes = { inside the class definition (as seen here https://babeljs.io/blog/2015/06/07/react-on-es6-plus).
There's also some possibility we need to turn on certain ES7 options to support this - which we should if true.
Bjvanminnen
reviewed
May 8, 2017
| stageNumber={config.stageNumber} | ||
| nextLevelPath={config.nextLevelPath} | ||
| />, | ||
| document.querySelector('.stage-extras') |
There was a problem hiding this comment.
any reason not to use an id instead of a className, as I assume we expect only one.
Bjvanminnen
reviewed
May 8, 2017
| @@ -0,0 +1,3 @@ | |||
| .stage-extras | |||
|
|
|||
| %script{src: minifiable_asset_path('js/scripts/stage_extras.js'), data: {extras: @stage_extras.to_json}} | |||
There was a problem hiding this comment.
good looking haml file :)
Bjvanminnen
approved these changes
May 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: https://docs.google.com/document/d/1sqquLVBZWs0p3tsYnfb5RhtAUKlWbkj3y-z9YBtrxEk/edit#heading=h.fjj8dwxbffev