Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define model in migration #14907

Merged
merged 1 commit into from May 8, 2017
Merged

define model in migration #14907

merged 1 commit into from May 8, 2017

Conversation

Bjvanminnen
Copy link
Contributor

@Bjvanminnen Bjvanminnen commented May 8, 2017

Folks running this migration are hitting an error:

Plc::Course#name delegated to course.name, but course is nil: #<Plc::Course id: 1, name: "Other plc course", created_at: "2016-08-15 23:29:03", updated_at: "2016-08-15 23:29:03", course_id: nil>

This is because the Plc::Course model changed in a subsequent PR, and began delegating name to ::Course

@Bjvanminnen Bjvanminnen requested review from wjordan and aoby May 8, 2017 16:53
@Bjvanminnen Bjvanminnen merged commit 64bd8d9 into staging May 8, 2017
@Bjvanminnen Bjvanminnen deleted the migrationDefineModel branch May 8, 2017 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants