Unit overview bugs #14910
Merged
Unit overview bugs #14910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
reviewed
May 8, 2017
| @@ -65,11 +66,11 @@ const ProgressDetailToggle = React.createClass({ | |||
| }, | |||
|
|
|||
| render() { | |||
| const { whiteBorder, isSummaryView, hasGroups } = this.props; | |||
| const { whiteBorder, isSummaryView, hasGroups, isPlc } = this.props; | |||
There was a problem hiding this comment.
That's funny... this should get coverage via the headless storybook tests.
islemaster
reviewed
May 8, 2017
| currentStageId={2} | ||
| /> | ||
| ); | ||
| assert.equal(wrapper.state('collapsed'), true); | ||
| }); | ||
|
|
||
| it('starts uncollapsed if it is the current stage', () => { | ||
| it('starts uncollapsed for teacher even if not the current stage', () => { |
There was a problem hiding this comment.
There's hole in your test matrix here:
| Is current stage | Not current stage | |
|---|---|---|
| Teacher | ✓ | |
| Student | ✓ | ✓ |
islemaster
approved these changes
May 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes for unit overview issues
(1) We want PLC courses to use teal instead of purple
(2) When you're a teacher, we want to make it so that all stages start uncollapsed.