Teacher app management page improvements #14943
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
program_registration_id
column toPd::TeacherApplications
, and updatedPdProgramRegistration
for to supply it, so we don't have to query pegasus to know if an associated registration exists. We still query to retrieve the up-to-date form including any edits from the UI.Include associated tables in the manage query, to prefetch and speed up the query (13 fold on my testing in the Rails console in production-console).
Add some basic paging to the manage view, because a list of 3000 applications in one page is just unwieldy even with the perf improvements.
Now the header looks something like this (with ~1k dummy applications on localhost):
Available page sizes:
Filtered: