Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teacher app management page improvements #14943

Merged
merged 2 commits into from May 9, 2017
Merged

Conversation

aoby
Copy link
Contributor

@aoby aoby commented May 9, 2017

  1. Add program_registration_id column to Pd::TeacherApplications, and updated PdProgramRegistration for to supply it, so we don't have to query pegasus to know if an associated registration exists. We still query to retrieve the up-to-date form including any edits from the UI.

  2. Include associated tables in the manage query, to prefetch and speed up the query (13 fold on my testing in the Rails console in production-console).

  3. Add some basic paging to the manage view, because a list of 3000 applications in one page is just unwieldy even with the perf improvements.

Now the header looks something like this (with ~1k dummy applications on localhost):
image

Available page sizes:
image

Filtered:
image

  1. Add requested ability to edit selected course for teacher applications.

Andrew Oberhardt added 2 commits May 9, 2017 10:02
@aoby aoby merged commit 67a914e into staging May 9, 2017
@aoby aoby deleted the teacher-app-mgmt-improvements branch May 9, 2017 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants