Create get_manifest helper. Variablize filename.downcase. #14972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, though @islemaster may want to take a look also if this is in response to his feedback in #14809 (comment) |
|
It is tangentially related. Mostly, though I haven't had the chance to spend much time on the bug, I'm struggling to fix the issue in #14809 without spaghetting the code worse than it already is. This PR establishes some tests (in the non-rename case) and does some drive-by cleanup on the way. |
islemaster
reviewed
May 10, 2017
| def files_put_file(encrypted_channel_id, filename, body) | ||
| bad_request if filename.downcase == FileBucket::MANIFEST_FILENAME | ||
| downcased_filename = filename.downcase | ||
| bad_request if downcased_filename == FileBucket::MANIFEST_FILENAME |
There was a problem hiding this comment.
:( Looks like coverage isn't getting reported correctly for shared tests? Maybe I'll take a look today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a few tests for existing functionality.