Update TYPES_WITHOUT_IDEAL_LEVEL_SOURCE. #14992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashercodeorg
changed the title
Bjvanminnen
reviewed
May 10, 2017
| # 'Maze', | ||
| # 'Studio', | ||
| # 'StudioEC', | ||
| # ] |
There was a problem hiding this comment.
presumably commented because we dont use this for anything atm?
There was a problem hiding this comment.
Correct. Though I think it is worth making explicit which level types do we have ideal level sources. Especially until we instrument a check, this confirms that the missing level types have been thought about.
There was a problem hiding this comment.
Would love to see that check added if this is important, rather than depending on people realizing this is somewhere they need to look/something they need to think about.
Bjvanminnen
approved these changes
May 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR is merged, I'll manually remove the
ideal_level_source_idif one exists, for all levels of level types being added toTYPES_WITHOUT_IDEAL_LEVEL_SOURCE.