Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the cron-project-hierarchy DMS task definition. #15101

Merged
merged 1 commit into from May 16, 2017

Conversation

ashercodeorg
Copy link
Contributor

@ashercodeorg ashercodeorg commented May 15, 2017

As the table has value values that exceed the column length imposed by Redshift, we are unable to import the column into Redshift in a straightforward manner via a DMS task. Thus, we remove it.

Given our removal of value, we remove updated_ip so as to allow placing the table in pegasus rather than pegasus_pii (this column is presumably not useful in Redshift).

"table-name": "storage_apps",
"column-name": "value"
},
"rule-action": "remove-column"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are you planning to determine whether a row represents a channel-backed level (as opposed to a standalone project)? The hidden field in the value column is where this bit lives today. The two ways I could see are (1) do a migration and add a new column, or (2) have redshift key off of whether "hidden": true or "hidden": "true" appear in the value field. Removing this column suggests the former, just wanting to confirm.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that (1) is the path of least resistance. Especially as I envision it might be useful to have an index on this (new) column in the production DB.

@ashercodeorg
Copy link
Contributor Author

Related: Do we have plans to back-populate storage_apps.project_type? Should I own doing so?

@davidsbailey
Copy link
Member

That would be great. @poorvasingal told me she thought you were doing the backfill of project_type, but if that's news to you then it sounds like we may be under-communicating on who's doing what on this project. The only thing I've been asked to do is populate project_type for new projects.

@davidsbailey
Copy link
Member

davidsbailey commented May 15, 2017 via email

@ashercodeorg
Copy link
Contributor Author

SGTM.

@poorvasingal
Copy link
Contributor

@ashercodeorg - If you could own backfilling the data, that'd be great. I'm trying to minimize the work Dave needs to put in before June 1, so we can meet the tight deadline for shipping the project gallery.

@ashercodeorg
Copy link
Contributor Author

As this PR is independent of ongoing schema changes to the storage_apps table, it is being merged.

@ashercodeorg ashercodeorg merged commit 1b63955 into staging May 16, 2017
@ashercodeorg ashercodeorg deleted the addCronProjectHierarchy branch May 16, 2017 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants