New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the cron-project-hierarchy DMS task definition. #15101
Conversation
35b7663
to
4037997
Compare
"table-name": "storage_apps", | ||
"column-name": "value" | ||
}, | ||
"rule-action": "remove-column" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are you planning to determine whether a row represents a channel-backed level (as opposed to a standalone project)? The hidden
field in the value
column is where this bit lives today. The two ways I could see are (1) do a migration and add a new column, or (2) have redshift key off of whether "hidden": true
or "hidden": "true"
appear in the value
field. Removing this column suggests the former, just wanting to confirm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that (1) is the path of least resistance. Especially as I envision it might be useful to have an index on this (new) column in the production DB.
Related: Do we have plans to back-populate |
That would be great. @poorvasingal told me she thought you were doing the backfill of |
Yes, it seems like some DB query time could be saved by adding an index on
that new column too.
|
SGTM. |
@ashercodeorg - If you could own backfilling the data, that'd be great. I'm trying to minimize the work Dave needs to put in before June 1, so we can meet the tight deadline for shipping the project gallery. |
As this PR is independent of ongoing schema changes to the |
As the table has
value
values that exceed the column length imposed by Redshift, we are unable to import the column into Redshift in a straightforward manner via a DMS task. Thus, we remove it.Given our removal of
value
, we removeupdated_ip
so as to allow placing the table inpegasus
rather thanpegasus_pii
(this column is presumably not useful in Redshift).