Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abandon the "Go Beyond" level type #15127

Merged
merged 2 commits into from May 16, 2017
Merged

Abandon the "Go Beyond" level type #15127

merged 2 commits into from May 16, 2017

Conversation

joshlory
Copy link
Contributor

Convert existing levels back to ExternalLink levels. Per conversation with @ryansloan we're no longer planning to use GoBeyond in Course A-F.

This reverts commit a323569.

# Conflicts:
#	dashboard/config/scripts/coursee-draft.script
#	dashboard/config/scripts/coursef-draft.script
@joshlory joshlory requested a review from balderdash May 16, 2017 17:43
@ashercodeorg
Copy link
Contributor

Should this also be removed?

@ashercodeorg
Copy link
Contributor

Do any of these levels exist on levelbuilder or production?

@joshlory
Copy link
Contributor Author

Yes — I'm keeping the empty model to avoid "subclass type does not exist" exceptions.

@joshlory
Copy link
Contributor Author

After the level changes are deployed to all environments I will remove the ideal level source ref @ashercodeorg mentioned above, and I'll clean up the remaining code changes from PR #14594.

@joshlory joshlory merged commit fae3668 into staging May 16, 2017
@joshlory joshlory deleted the nuke-go-beyond branch May 16, 2017 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants