Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projects gallery style polish #15147

Merged
merged 3 commits into from May 17, 2017
Merged

Conversation

caleybrock
Copy link
Contributor

screen shot 2017-05-16 at 4 32 22 pm

Up next, I'll do the UI for the gallery switcher.

@Erin007
Copy link
Contributor

Erin007 commented May 17, 2017

The teal links > in all of the navigation redesign are bold. @tanya should the links be bold or not - no opinion on my end, but they should be consistent.

<a href="#gallery-switcher"><button>Back to top</button></a>
<ProgressButton
href="#gallery-switcher"
color="gray"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it makes Brent happy when this is color={ProgressButton.ButtonColor.gray}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃

Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@caleybrock caleybrock merged commit 1a46ebf into staging May 17, 2017
@caleybrock caleybrock deleted the projects-gallery-style-polish branch May 17, 2017 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants