Insert blocks into remixed playlab levels to handle different level settings #15207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
May 17, 2017 12:54
joshlory
approved these changes
May 22, 2017
| // The excluded app types need to make modifications to the project that | ||
| // apply to the remixed project, but should not be saved on the original | ||
| // project. See (Turtle|Studio).prepareForRemix(). | ||
| return !['turtle', 'studio'].includes(appOptions.app); |
There was a problem hiding this comment.
What happens if I try to remix one of these apps while logged out?
There was a problem hiding this comment.
Ah, yeah it used to force you to log in and I broke that. Fixed by just disabling the last save.
| @@ -2,6 +2,7 @@ import Collidable from './collidable'; | |||
| import * as constants from './constants'; | |||
| import _ from 'lodash'; | |||
| import { ShakeActor } from './spriteActions'; | |||
| import Studio from './studio'; | |||
There was a problem hiding this comment.
Is Studio already global?
There was a problem hiding this comment.
Yes, but it seems to get set somewhere that doesn't run in these unit tests. This file is completely untested 😿
This was referenced May 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differing map layouts lead to a bunch of generated blocks, e.g.
Before Remix:
After Remix:
There would be even more if the original level also specified custom sprites/emotions/sizes/speeds.