Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow navigation to /courses while logged out #15218

Merged
merged 1 commit into from May 19, 2017
Merged

allow navigation to /courses while logged out #15218

merged 1 commit into from May 19, 2017

Conversation

Bjvanminnen
Copy link
Contributor

@Bjvanminnen Bjvanminnen commented May 19, 2017 •
edited

Makes it so that you can go to /courses (via the index action) even when not logged in.

check_authorization is redundant in the case where we also have authorize_resource without exceptions, so I've removed that.

Erin007
Erin007 approved these changes May 19, 2017
View reviewed changes
Copy link
Contributor

@Erin007 Erin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Bjvanminnen!

breville
breville approved these changes May 19, 2017
View reviewed changes
Copy link
Member

@breville breville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Bjvanminnen Bjvanminnen merged commit 88be88e into staging May 19, 2017
@Bjvanminnen Bjvanminnen deleted the coursesAuth branch May 19, 2017 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breville breville breville approved these changes

@Erin007 Erin007 Erin007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Bjvanminnen @breville @Erin007