Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Connection] Connection status verification #15242

Merged
merged 1 commit into from May 24, 2017

Conversation

dostos
Copy link
Contributor

@dostos dostos commented May 19, 2017

Connection status check on launch / run button click
Popup modal to alert

@joshlory joshlory self-assigned this May 19, 2017
@dostos dostos force-pushed the minecraft-cc-connectionStatus branch 2 times, most recently from f2d0752 to 19dca6e Compare May 20, 2017 01:14

.download-button {
border-style: solid !important;
border-width: 4px 5px 6px !important;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shorthands of length 3 are not allowed. Value was 4px 5px 6px

@dostos dostos force-pushed the minecraft-cc-connectionStatus branch from 2a6262c to f89cba7 Compare May 24, 2017 21:28
@joshlory joshlory merged commit 2ed9b23 into code-dot-org:staging May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants