Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop writing Level.solution_level_source_id to files. #15259

Merged
merged 1 commit into from May 23, 2017

Conversation

ashercodeorg
Copy link
Contributor

@ashercodeorg ashercodeorg commented May 22, 2017

As an initial step towards removing the solution_level_source_id column from the levels table, we stop persisting it to files. The following further work is planned.

  1. Let this PR reach all environments.
  2. Remove solution_level_source_id from all .level files on levelbuilder.
  3. Let the updated .level files reach all environments.
  4. Remove the solution_level_source_id column from the levels table via a migration.
  5. Revert this PR (remove blacklisting solution_level_source_id).

@ashercodeorg
Copy link
Contributor Author

@Hamms, please confirm that my deprecation plan is sensical (correct).

Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a great plan to me!

@ashercodeorg ashercodeorg merged commit 303ad6f into staging May 23, 2017
@ashercodeorg ashercodeorg deleted the stopWritingSolutionLevelSourceId branch May 23, 2017 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants