Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement feedback from Workshop Survey bug bash #15278

Merged
merged 7 commits into from May 23, 2017

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented May 22, 2017

feedback doc

  • Make sure that who_facilitated is being set even when there's only one facilitator
  • Support facilitator names that might be underscored *
  • Mark all facilitator-specific questions as required
  • Scroll to top of page rather than top of form on state change (with the removal of the disclaimer from the header of every page, this makes for a much cleaner experience)
  • Update some copy

(* Note: this is a bit weird, because we're storing the values for those entries as a "flattened" set of key/value pairs in the db, so the names of the facilitators are going through the same transformations as our keys. I'm going to address this a better way in a separate PR.)

@Hamms Hamms force-pushed the workshop-survey-improvements branch from d469c89 to 54366c1 Compare May 22, 2017 21:52
@Hamms Hamms merged commit 7495588 into staging May 23, 2017
@Hamms Hamms deleted the workshop-survey-improvements branch August 22, 2017 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants