Create SolrHelper module. #15284
Merged
Create SolrHelper module. #15284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashercodeorg
commented
May 22, 2017
| end | ||
|
|
||
| def update_document_type_user(db_id, solr_id) | ||
| db_user = DASHBOARD_DB[:users].find_by_id(db_id) |
There was a problem hiding this comment.
The bug fix is here, this should be using the where syntax.
There was a problem hiding this comment.
it's not clear to me why where().first is better than find
There was a problem hiding this comment.
Because find is ActiveRecord syntax, not Sinatra syntax. Though I'd consider it less readable as corrected, it works this way. :)
|
Note that I'm choosing not to put this in |
|
I dont have much/any expertise in this area of the code, but change looks fine to me. |
Hamms
approved these changes
May 23, 2017
| end | ||
|
|
||
| def update_document_type_user(db_id, solr_id) | ||
| db_user = DASHBOARD_DB[:users].find_by_id(db_id) |
There was a problem hiding this comment.
it's not clear to me why where().first is better than find
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly a copy-and-paste, with a bug fix as well. This PR is motivated by wanting access to the
delete_documentmethod from #15210.