Log the contained level id as the attempted level id #15321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlory
approved these changes
May 23, 2017
| @@ -204,7 +204,7 @@ def user_progress_for_stage | |||
| slog( | |||
| tag: 'activity_start', | |||
| script_level_id: script_level.try(:id), | |||
| level_id: level.id, | |||
| level_id: level.contained_levels.empty? ? level.id : level.contained_levels.first.id, | |||
There was a problem hiding this comment.
Is there a reason we are logging only the first contained level, rather than logging all of them?
There was a problem hiding this comment.
We don't actually render more than one contained level anywhere. There's one level that has multiple contained levels, but it only shows the first and isn't actually used in a script: https://levelbuilder-studio.code.org/levels/4562
There was a problem hiding this comment.
Then why do we store it as an array?
There was a problem hiding this comment.
I'm guessing there was a plan to one day support multiple, but nobody got around to that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Milestone posts from contained level completions use the level id of the contained level. At the moment, the api_controller is still logging the attempts under the level id of the outer level, rather than contained level. This mismatch is giving us a bunch of spurious activitymonitor complaints.
This PR updates the logging of the level attempt to use the contained level id as well (when present). Logentry logs are only consumed by activitymonitor, so this shouldn't mess with anything else.