Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove build_scripts from crontab cronjobs. #15339

Merged
merged 1 commit into from May 25, 2017
Merged

Remove build_scripts from crontab cronjobs. #15339

merged 1 commit into from May 25, 2017

Conversation

ashercodeorg
Copy link
Contributor

A prerequisite step towards actually removing the script in #15100.

Per product, this pipeline is no longer necessary.

Hamms
Hamms approved these changes May 25, 2017
View reviewed changes
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cautiously LGTM, assuming you're completely confident that this is no longer needed.

@ashercodeorg
Copy link
Contributor Author

That's what product says. And if anyone changes their mind, it'd be easy to (a) revert this PR and (b) run the script manually (if necessary).

@ashercodeorg ashercodeorg merged commit 6fd206d into staging May 25, 2017
@ashercodeorg ashercodeorg deleted the decronBuildScripts branch May 25, 2017 20:23
@ashercodeorg ashercodeorg mentioned this pull request May 25, 2017
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hamms Hamms Hamms approved these changes

@wjordan wjordan Awaiting requested review from wjordan

Assignees
No one assigned
Labels
code-hygiene
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashercodeorg @Hamms