Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename legacy share Save button to Save and Publish #15353

Merged
merged 1 commit into from May 24, 2017
Merged

rename legacy share Save button to Save and Publish #15353

merged 1 commit into from May 24, 2017

Conversation

davidsbailey
Copy link
Member

This rename takes affect regardless of whether the projectsGallery flag is enabled, which seems fine since the wording change is still accurate without the flag being enabled.

caleybrock
caleybrock approved these changes May 24, 2017
View reviewed changes
Copy link
Contributor

@caleybrock caleybrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ltgm. did a quick search to make sure that string is only used in the one location, so I think a replace should work.

@davidsbailey
Copy link
Member Author

thanks for double-checking!

@davidsbailey davidsbailey merged commit 97115a3 into staging May 24, 2017
@davidsbailey davidsbailey deleted the rename-save-and-publish branch May 24, 2017 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleybrock caleybrock caleybrock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidsbailey @caleybrock