Fix SCSS lint errors in craft/style.scss #15380
Conversation
| @@ -400,7 +405,7 @@ $height-to-width: 434 / 477; | |||
|
|
|||
| #craft-popup-connect { | |||
| @include reset-dialog; | |||
| background-color: #3C3C3C; | |||
| background-color: $almost-very-dark-gray; | |||
There was a problem hiding this comment.
With names like these, are we really making things that much clearer by using english vs. hex codes?
There was a problem hiding this comment.
I'm not sure about clearer, but I think it's useful in the sense that you end up with this block near the top of the file:
$darkest-gray: #333;
$very-dark-gray: #3b3b3b;
$almost-very-dark-gray: #3c3c3c;
It amplifies a couple of style-smells: That we are using three near-identical colors, and that we don't have a semantic name for any of them (where colors $button-text-white and $header-text-yellow are more obviously useful because it's clear when/where to use them in the future). I'm not bothering to fix that here because I'd like this to be a pure refactor, but I think it's more likely to get cleaned up next time somebody works on these colors if they're grouped like that.
Hound complained about some SCSS lint errors in craft/style.scss on this DTT which it's not supposed to do so we might disable Hound for SCSS altogether. However, these were easy to clean up (and not a bad idea) so I'm cleaning them up anyway.