Data tab applab instructions #15381
Merged
Data tab applab instructions #15381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,13 @@ | |||
| @no_mobile | |||
| @dashboard_db_access | |||
There was a problem hiding this comment.
this test shouldn't need dashboard db access. please try removing this line, and then confirming that it passes on CircleCI or by running the test locally (I can help you with that).
| @@ -61,6 +61,9 @@ const DataOverview = React.createClass({ | |||
| <div id="dataOverview" style={{display: visible ? 'block' : 'none'}}> | |||
| <h4>Data</h4> | |||
|
|
|||
| <h5>{msg.dataTabExplanation()} <a id="dataBlocksLink" href="https://code.org/applab/docs/tabledatastorage"><strong>{msg.dataBlocks()}</strong></a> {msg.withinApp()}</h5> | |||
| <br/> | |||
There was a problem hiding this comment.
unfortunately, because different languages have different grammar, this isn't an i18n (internationalization) friendly way to construct a string. Fortunately, our translation system has the ability to include placeholders in a string. Here is a simple example of the completedWithoutRecommendedBlock ui string using a placeholder:
- https://github.com/code-dot-org/code-dot-org/blob/staging/apps/i18n/common/en_us.json#L37
- https://github.com/code-dot-org/code-dot-org/blob/staging/apps/src/feedback.js#L799-L801
Ideally you would do something like the following:
- define a
dataBlocksLinkvariable to save the<a id="dataBlocksLink" href="https://code.org/applab/docs/tabledatastorage"><strong>{msg.dataBlocks()}</strong>snippet from your above code that renders msg.dataBlocks into a string - create a single, longer ui string containing your
dataTabExplanation, then a placeholder for the dataBlocksLink, then the contents of yourwithinAppstring - inject your
dataBlocksLinkin as the placeholder
added 2 commits
May 25, 2017 16:38
internationalization.
checked the redirect location.
|
@davidsbailey PTAL. Thanks! |
|
Nice progress Erin. Could you please include a screenshot of how this is looking? |
davidsbailey
approved these changes
May 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Axosoft
Added explanatory text and captions to the data tab in applab.