Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update bramble, light-theme, files API feedback #15388

Merged
merged 1 commit into from May 26, 2017
Merged

update bramble, light-theme, files API feedback #15388

merged 1 commit into from May 26, 2017

Conversation

cpirich
Copy link
Contributor

@cpirich cpirich commented May 25, 2017

  • Update Bramble to version 0.1.16 (changes here: code-dot-org/bramble@062f7a5)
    • Prevents the sidebar from being hidden when only 1 file is in the project
    • Changes the sidebar to a light theme
  • Request that the Bramble light-theme is applied
  • Minor changes to files API and tests based on previous PR feedback

@cpirich cpirich requested a review from islemaster May 25, 2017 19:12
@cpirich cpirich merged commit 1534590 into staging May 26, 2017
@cpirich cpirich deleted the weblab_update_bramble_0.1.16 branch May 26, 2017 03:30
islemaster
islemaster reviewed May 26, 2017
View reviewed changes
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islemaster islemaster islemaster left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cpirich @islemaster