only validate form data when changed #15389
Conversation
|
|
||
| def rollback! | ||
| restore_attributes | ||
| end |
There was a problem hiding this comment.
Might this be simpler to derive DummyForm from ActiveRecord::Base?, and not have to implement these?
There was a problem hiding this comment.
Unfortunately, doing so means that it also wants to persist the data to the DB, which I don't care about for this test.
There was a problem hiding this comment.
But there's no harm right? Unit tests are run on the test environment (db) and also in a transaction so they won't actually leave anything behind. I think it would make the below test more readable.
There was a problem hiding this comment.
The problem is that I'd have to actually create a table for the dummy class, otherwise I get
Pd::FormTest
test_pd_form_enforces_required_fields ERROR (0.01s)
ActiveRecord::StatementInvalid: ActiveRecord::StatementInvalid: Mysql2::Error: Table 'dashboard_test.dummy_forms' doesn't exist: SHOW FULL FIELDS FROM `dummy_forms`
test/models/concerns/pd/form_test.rb:43:in `block in <class:FormTest>'
test/testing/setup_all_and_teardown_all.rb:22:in `run'
Let me poke around and see if there's a way I can inherit from ActiveRecord::Base and just tell it not to try to do that; I agree it would be much cleaner.
There was a problem hiding this comment.
Oh right, I forgot each of these was a separate model, rather than the same with STI.
Maybe you can stub save and persisted? ? No need to spend a lot of time on this if it's complicated.
| form.form_data = {firstField: "bar"}.to_json | ||
| assert_equal false, form.valid? | ||
| end | ||
|
|
There was a problem hiding this comment.
I don't get what this is testing. Why is foo valid and bar invalid? Also I'd like to explicitly see the case where an "invalid" form data is grandfathered in via save(validate: false), then shown to be valid unless modified.
nit: refute instead of assert_equal false,
There was a problem hiding this comment.
ahh, yeah, I can see how this is unclear.
That is essentially what I'm doing here; the only difference is that this dummy form I've constructed doesn't actually perform validation on save. Or, in other words, it always treats a save call as a save(validate: false).
Do you think adding comments explaining exactly what's going on here would be sufficiently clear? Or do I need to rethink this whole "DummyForm" idea?
There was a problem hiding this comment.
See above. I think it might be worth (and simpler) persisting to the (test) db. Otherwise yes please add comments.
|
Turns out it's pretty easy to just instantiate a temporary table to hold the ActiveRecord data! Much cleaner than what I was originally trying for. PTAL |
Addressing this comment