Payment Calculator adjustments. Don't pay the fixed payment if the mi… #15393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nimum isn't met, and use enrollments, not attendees when determining if the minimum was hit (but keep attendees for the maximum)
aoby
reviewed
May 25, 2017
| @@ -42,8 +42,8 @@ def calculate_workshop_payment(workshop) | |||
| payment_sum = payment_term.fixed_payment || 0 | |||
|
|
|||
| if payment_term.minimum_attendees_for_payment? && | |||
| attending_teachers.size < payment_term.minimum_attendees_for_payment | |||
| return payment_sum | |||
| workshop.enrollments.size < payment_term.minimum_attendees_for_payment | |||
There was a problem hiding this comment.
if this is about enrollments now, should we rename the field mimimum_enrollments_for_payment?
aoby
approved these changes
May 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nimum isn't met, and use enrollments, not attendees when determining if the minimum was hit (but keep attendees for the maximum)