Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maker Overlay design adjustments #15421

Merged
merged 1 commit into from
May 30, 2017
Merged

Conversation

islemaster
Copy link
Contributor

Changes suggested by Mark after demos today (we should get him on GitHub so I can tag him in stuff like this):

  • Makes all buttons as wide as the widest button.
  • Removes the period after "Chrome 33+."
Before After
screenshot from 2017-05-26 13-21-19 screenshot from 2017-05-26 13-19-56

- Makes all buttons as wide as the widest button.
- Removes the period after "Chrome 33+."
<div
style={{
display: 'flex',
flexDirection:'row',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat. does this work in all our supported browsers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does indeed! CanIUse reports full support with some IE11 caveats, so I verified on IE11/Win7:

screenshot from 2017-05-30 10-33-47

Copy link
Member

@breville breville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with flex syntax yet but I like the results and the React wrapper looks like a neat solution.

@islemaster islemaster merged commit a8d607e into staging May 30, 2017
@islemaster islemaster deleted the maker-overlay-style-fixes branch May 30, 2017 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants