don't show abusive projects in the public gallery #15566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bjvanminnen
approved these changes
Jun 1, 2017
|
Can/should we write tests for this? |
|
we don't actually have any test coverage of the DB query itself -- in unit tests we are stubbing the value of the dataset that is returned. It looks theoretically possible to unit test the query code via Sequel-Fixture. We could also do a UI test to get end-to-end coverage for the abuse case in particular. These would be complicated slightly because we cache the public gallery data fetch for 1 minute. |
|
Do either of these seem worth pursuing as part of this PR? |
|
Your call. If it seems super difficult, perhaps not. |
|
Merging this now since it seems urgent, and testing it properly by either means seems like a half to whole day endeavor. I will make a note to cover this case when we add UI tests for this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verified manually that projects marked as abusive can be "published" but then don't show up in the public gallery