Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning for DB changes to DOTD script. #15651

Merged
merged 2 commits into from Jun 8, 2017
Merged

Add warning for DB changes to DOTD script. #15651

merged 2 commits into from Jun 8, 2017

Conversation

ashercodeorg
Copy link
Contributor

@ashercodeorg ashercodeorg commented Jun 6, 2017 •
edited

Though this is not the most convenient place to warn (it would seem better to warn before asking about DTPing), it is the most expedient.

Example:
image

@ashercodeorg
Copy link
Contributor Author

Note that my query picks up changes to, e.g., dashboard/db/schema.rb. This seems desirable to me, though probably debatable.

@ashercodeorg
Copy link
Contributor Author

CircleCI failure is unrelated.

@ashercodeorg ashercodeorg merged commit d408933 into staging Jun 8, 2017
@ashercodeorg ashercodeorg deleted the warnOnMigration branch June 8, 2017 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bjvanminnen Bjvanminnen Bjvanminnen approved these changes

@joshlory joshlory Awaiting requested review from joshlory

@mehalshah mehalshah Awaiting requested review from mehalshah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashercodeorg @Bjvanminnen