MazeThumbnail React component and Storybook entry
#15692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
approved these changes
Jun 12, 2017
There was a problem hiding this comment.
this looks great! I love seeing code move out of maze.js and into more isolated components.
It does seem a little funky for the start and finish coords to live on subtype but be exclusively controlled by maze; I'd love to (perhaps as another PR) see more of that code moved down to the subtype level.
| Maze.start_ = {x: x, y: y}; | ||
| Maze.finish_ = {x: x, y: y}; | ||
| Maze.subtype.start = {x: x, y: y}; | ||
| Maze.subtype.finish = {x: x, y: y}; |
There was a problem hiding this comment.
given that start and finish have been moved to subtype, could this also be moved there?
There was a problem hiding this comment.
There's definitely more refactoring to do but I'm tempted to save it for a future PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract maze
drawMapto a separate file, and re-use it to render aMazeThumbnailReact component. Only one skin is currently supported. The thumbnail doesn't (yet) show the start or finish icons.