add buttons directly to new CSD and CSP course overview pages #15799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erin007
approved these changes
Jun 13, 2017
| @@ -5,7 +5,7 @@ video_player: true | |||
| theme: responsive | |||
| --- | |||
|
|
|||
| # Our newest course: CS Discoveries # | |||
| # Our newest course: CS Discoveries [<button style="margin-top:0;">View course</button>](https://studio.code.org/courses/csd) | |||
There was a problem hiding this comment.
Do we want relative links here?
| @@ -5,7 +5,7 @@ video_player: true | |||
| theme: responsive | |||
| --- | |||
|
|
|||
| # Our newest course: CS Discoveries # | |||
| # Our newest course: CS Discoveries [<button style="margin-top:0;">View course</button>](https://studio.code.org/courses/csd) | |||
|
|
|||
| ## <a name="what"></a>What is CS Discoveries? | |||
There was a problem hiding this comment.
This name isn't descriptive. Maybe name="CSDlink" or something related?
There was a problem hiding this comment.
Oh I thought you wanted me to add a name to my link. hahah I see this is existing stuff. It's not the best, but I don't want to update this because Josh made these anchor links. I could update site wide but he may already be using these links in his resources. Considering how small a difference the name makes, I don't think it's worth cleaning up now but I can include a tip in our editor guides about choosing more descriptive names for future times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSD
CSP Desktop
CSP Tablet
CSP Mobile
