don't send exit survey emails for FIT weekend workshops #15820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -174,13 +174,21 @@ def exit_survey_url | |||
| end | |||
| end | |||
|
|
|||
| def should_send_exit_survey? | |||
| return false if workshop.fit_weekend? | |||
There was a problem hiding this comment.
This could be !workshop.fit_weekend??
|
As trivial as these methods are, some tests would be nice. |
Hamms
force-pushed
the
dont-send-fit-exit-surveys
branch
from
356874a
to
0cf09bd
Compare
|
PTAL |
aoby
approved these changes
Jun 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.