Update use of private interpreter variables to have underscore suffix #15849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlory
approved these changes
Jun 14, 2017
pcardune
force-pushed
the
pcardune-more-codegen-stuff
branch
from
b7fe401
to
2995b7b
Compare
The names changed in the interpreter, so they needed to get updated.
pcardune
force-pushed
the
pcardune-more-interpreter-upgrades
branch
from
ee20bfc
to
1e6274c
Compare
|
yes, but I'll probably wait until Monday to merge it (and others) anyway. |
|
Ok, this change is not good. While all of our tests pass, the interpreter test suite indicates that the most recent merges from Neil's branch broke The break was fixed 19 commits later, so I'm going to try to merge in those 19 commits and hope no other private APIs were changed. We'll see. |
This is needed to get a9ae586 (Proper 'this' boxing in non-strict mode.) from the interpreter to work
|
ok, now this should be ready to go for reals. |
pcardune
changed the base branch from
pcardune-more-codegen-stuff
to
pcardune-blessed-interpreter-upgrades
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of private interpreter APIs got underscores added to the end of them. This PR updates our code to reference the new names.