Make test status page work on Firefox #15886
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@epeach noticed today that the test status page was silently failing to update on Firefox (while working fine on Chrome). After some investigation I narrowed the issue down to a failure to parse the test suite start time.
The default Ruby
Time.to_s
format%Y-%m-%d %H:%M:%S %z
is parsed in Chrome but not in Firefox. As noted above, removing the space before the timezone%Y-%m-%d %H:%M:%S%z
makes the time parse in both browsers, but it's also not a valid RFC2822 or ISO 8601 date which is whatDate.parse
is documented to accept. Therefore we are now using ISO 8601 (looks like2017-06-15T12:46:11-07:00
).I also added doctype and charset metadata to the test status page to silence warnings showing up in Firefox's console. Because of that, you may want to view this diff without whitespace changes.