Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test status page work on Firefox #15886

Merged
merged 2 commits into from Jun 15, 2017
Merged

Conversation

islemaster
Copy link
Contributor

@islemaster islemaster commented Jun 15, 2017

@epeach noticed today that the test status page was silently failing to update on Firefox (while working fine on Chrome). After some investigation I narrowed the issue down to a failure to parse the test suite start time.

Chrome Firefox
pasted image at 2017_06_15 12_33 pasted image at 2017_06_15 12_33 1

The default Ruby Time.to_s format %Y-%m-%d %H:%M:%S %z is parsed in Chrome but not in Firefox. As noted above, removing the space before the timezone %Y-%m-%d %H:%M:%S%z makes the time parse in both browsers, but it's also not a valid RFC2822 or ISO 8601 date which is what Date.parse is documented to accept. Therefore we are now using ISO 8601 (looks like 2017-06-15T12:46:11-07:00).

I also added doctype and charset metadata to the test status page to silence warnings showing up in Firefox's console. Because of that, you may want to view this diff without whitespace changes.

Makes it parseable in both Chrome and Firefox, fixing status page on Firefox.
@islemaster
Copy link
Contributor Author

Uh... Circle is failing to install yarn?

$ yarn --version
bash: line 1: yarn: command not found

yarn --version returned exit code 127

Action failed: yarn --version

I wonder what's up.

@islemaster islemaster merged commit 94f45e5 into staging Jun 15, 2017
@islemaster islemaster deleted the firefox-test-status-page branch June 15, 2017 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants