Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add puzzle piece version of throw projectile #15922

Merged
merged 6 commits into from Jul 11, 2017
Merged

Add puzzle piece version of throw projectile #15922

merged 6 commits into from Jul 11, 2017

Conversation

balderdash
Copy link
Contributor

image

@balderdash balderdash requested a review from Hamms June 16, 2017 23:55
Hamms
Hamms requested changes Jun 20, 2017
View reviewed changes
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to see this and studio_throw combined using addRegularAndParamsVersions

@balderdash
Copy link
Contributor Author

@Hamms Switched to using addRegularAndParamsVersions. I had to move the parts of that function that only applied to if/else blocks.

Hamms
Hamms approved these changes Jul 11, 2017
View reviewed changes
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for doing that cleanup.

LGTM

@balderdash balderdash merged commit 52703d1 into staging Jul 11, 2017
@balderdash balderdash deleted the throw-puzzle branch July 13, 2017 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hamms Hamms Hamms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@balderdash @Hamms