Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not show right-arrow for adding params to function calls in starwars levels #16000

Merged
merged 1 commit into from Jun 21, 2017

Conversation

davidsbailey
Copy link
Member

Some recent droplet changes added arrow buttons to function calls to add/subtract params on function call blocks. we don't want to show these arrows in starwars levels. fortunately there is already an easy way to configure this on a per-level basis.

screen shot 2017-06-21 at 10 26 42 am

https://eyes.applitools.com/app/sessions/00000251904252056253/00000251904251860188/steps/6?&parent=nexcj1m&accountId=mG4DoRfv0ntEgI3XIYBulrKxlZqrHtGwbP3V103ojvLFU110

this regression isn't a ship blocker, so I'm just going to make the fix and if the regression happens to get shipped before the fix we won't be too sad.

Copy link
Member

@breville breville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@davidsbailey davidsbailey merged commit 4915d56 into staging Jun 21, 2017
@davidsbailey davidsbailey deleted the lock-zero-params-starwars branch June 21, 2017 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants