Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait until the user header has loaded in most ui tests #16011

Merged
merged 2 commits into from Jun 21, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 8 additions & 8 deletions dashboard/test/ui/features/sharepageLogo.feature
Expand Up @@ -8,7 +8,7 @@ Feature: Lab share page logo
Then I click selector ".project_share"
And I wait until element "#sharing-input" is visible
And I navigate to the share URL
And I wait for the page to fully load
And I wait to see "#runButton"
And element "div:contains('STUDIO')" does not exist
And I press "logo-img" to load a new page
And check that I am on "http://studio.code.org/courses"
Expand All @@ -20,7 +20,7 @@ Feature: Lab share page logo
Then I click selector ".project_share"
And I wait until element "#sharing-input" is visible
And I navigate to the share URL
And I wait for the page to fully load
And I wait to see "#runButton"
And element "div:contains('STUDIO')" does not exist
And I press "logo-img" to load a new page
And check that I am on "http://studio.code.org/courses"
Expand All @@ -32,7 +32,7 @@ Feature: Lab share page logo
Then I click selector ".project_share"
And I wait until element "#sharing-input" is visible
And I navigate to the share URL
And I wait for the page to fully load
And I wait to see "#runButton"
And element "div:contains('STUDIO')" does not exist
And I press "logo-img" to load a new page
And check that I am on "http://studio.code.org/courses"
Expand All @@ -44,7 +44,7 @@ Feature: Lab share page logo
Then I click selector ".project_share"
And I wait until element "#sharing-input" is visible
And I navigate to the share URL
And I wait for the page to fully load
And I wait to see "#runButton"
And element "div:contains('STUDIO')" does not exist
And I press "logo-img" to load a new page
And check that I am on "http://studio.code.org/courses"
Expand All @@ -56,7 +56,7 @@ Feature: Lab share page logo
Then I click selector ".project_share"
And I wait until element "#sharing-input" is visible
And I navigate to the share URL
And I wait for the page to fully load
And I wait to see "#runButton"
And I am on "http://studio.code.org/users/sign_out"
And I reload the page
And I navigate to the last shared URL
Expand All @@ -71,7 +71,7 @@ Feature: Lab share page logo
Then I click selector ".project_share"
And I wait until element "#sharing-input" is visible
And I navigate to the share URL
And I wait for the page to fully load
And I wait to see "#runButton"
And I am on "http://studio.code.org/users/sign_out"
And I reload the page
And I navigate to the last shared URL
Expand All @@ -86,7 +86,7 @@ Feature: Lab share page logo
Then I click selector ".project_share"
And I wait until element "#sharing-input" is visible
And I navigate to the share URL
And I wait for the page to fully load
And I wait to see "#runButton"
And element "#main_logo" does not exist

@only_mobile
Expand All @@ -96,5 +96,5 @@ Feature: Lab share page logo
Then I click selector ".project_share"
And I wait until element "#sharing-input" is visible
And I navigate to the share URL
And I wait for the page to fully load
And I wait to see "#runButton"
And element "#main_logo" does not exist
1 change: 1 addition & 0 deletions dashboard/test/ui/step_definitions/steps.rb
Expand Up @@ -104,6 +104,7 @@ def individual_steps(steps)
steps <<-STEPS
When I wait to see "#runButton"
And I close the instructions overlay if it exists
And I wait to see ".header_user"
STEPS
end

Expand Down