Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update droplet to commit e388cd8c54501855b40dd4e767e8a0c94789c3b2 #16022

Merged
merged 1 commit into from Jun 22, 2017
Merged

update droplet to commit e388cd8c54501855b40dd4e767e8a0c94789c3b2 #16022

merged 1 commit into from Jun 22, 2017

Conversation

cpirich
Copy link
Contributor

@cpirich cpirich commented Jun 22, 2017 •
edited

  • Update droplet
  • A previous change to properly handle either socket.dropdown or socket.dropdown.generate didn't take into account that some dropdown functions expected the this parameter to be the socket. That is now fixed.

@davidsbailey
Copy link
Member

LGTM

@cpirich cpirich merged commit 2750fcc into staging Jun 22, 2017
@cpirich cpirich deleted the droplet_dropdown_this_parameter branch June 22, 2017 15:04
islemaster
islemaster reviewed Jun 22, 2017
View reviewed changes
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing Chris!

Out of curiosity, do we have any plans to depend on droplet via NPM instead of having a copy checked in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islemaster islemaster islemaster left review comments

@davidsbailey davidsbailey Awaiting requested review from davidsbailey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cpirich @davidsbailey @islemaster