Actually preload first hero image on homepage #16025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup to #16002.
tanyaparker
pushed a commit
that referenced
this pull request
Jun 28, 2017
Followup to #16025. [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small followup/fix to #16002. The previous PR still unintentionally included the
.lazyloadclass on the first hero image, which caused it to delay loading until the lazysizes library had loaded. This fix will cause the first hero image to render as soon as it downloads.I've also swapped the
<link rel=preload>tags out forLink, rel=preloadHTTP response headers, which will allow the preloading to begin earlier in the page-load process (as soon as the HTTP-response headers are received, rather than after the full HTTP-response body is received and parsed).Also added a few more comments for clarity.