Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce dashboard_workers from 6 to 5 on circle #16115

Merged
merged 1 commit into from Jun 27, 2017
Merged

Conversation

davidsbailey
Copy link
Member

@davidsbailey davidsbailey commented Jun 27, 2017

No description provided.

@davidsbailey
Copy link
Member Author

The goal of this PR is to avoid out of memory errors when running UI tests. example failure:

Decrementing the number of workers should save almost 1GB out of 8GB per container during UI tests.

Performance measurements

There has been some suspicion that decreasing the number of dashboard workers could substantially reduce UI test performance, however recent analysis suggests this is unfounded.

The run_ui_tests step took 1:08:10 on this PR: https://circleci.com/gh/code-dot-org/code-dot-org/41255#tests/containers/1 . The times for the same step on the past 5 successful staging builds took: [1:06:30, 1:11:18, 1:09:38, 1:07:12, 1:01:46] (average: 1:07:17).

Though this could represent a 1-minute slowdown, it seems within the noise margin so I'd propose we go ahead with this change and look at how UI test performance is affected over the course of the week.

Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davidsbailey davidsbailey merged commit 3de0c9e into staging Jun 27, 2017
@davidsbailey davidsbailey deleted the circle-5-workers branch June 27, 2017 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants