Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert project gallery from 1000px to 970px #16165

Merged
merged 3 commits into from Jun 30, 2017
Merged

Conversation

caleybrock
Copy link
Contributor

The header for this isn't perfect, but I think we should consider updating the HeadingBanner in a separate PR once /courses and /home is done because it'll affect other pages.

Production:
screencapture-studio-code-org-projects-1498766219181

Staging after my changes:
screencapture-localhost-studio-code-org-3000-projects-1498766191570

cc @tanyaparker @Erin007

@tanyaparker
Copy link
Contributor

By header isn't perfect do you mean the component with the "My Projects" and "Public Gallery" tabs?

@tanyaparker
Copy link
Contributor

Or did you mean the "Project Gallery" title doesn't left align with the rest of the page components?

@caleybrock
Copy link
Contributor Author

@tanyaparker yep, those were made for 960px (which I'm not sure what matches) so it doesn't line up perfectly.

@caleybrock
Copy link
Contributor Author

@tanyaparker the "Project Gallery" and the tabs are in one component, so those line up, they are just slightly off with the rest of the page.

Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good.

Seems to me like it would it be better to left-align Playlab, Artist etc. with Projects Gallery and the gallery switcher, however I'll let you all decide how it should look:
screen shot 2017-06-29 at 2 19 00 pm

Please make sure you also look at this:

  • with the My Projects tab selected
  • while signed out

@tanyaparker
Copy link
Contributor

Great suggestions, Dave. +1

@caleybrock
Copy link
Contributor Author

Good call. I updated that with the expectation that we may have to adjust a bit again.
screencapture-localhost-studio-code-org-3000-projects-1498772923174

@davidsbailey
Copy link
Member

This looks better! Thanks for changing.

@caleybrock caleybrock merged commit a835083 into staging Jun 30, 2017
@caleybrock caleybrock deleted the project-gallery-970 branch June 30, 2017 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants