Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify mobile viewport with initial-scale=1 on share pages #16222

Merged
merged 1 commit into from Jul 5, 2017

Conversation

joshlory
Copy link
Contributor

@joshlory joshlory commented Jul 5, 2017

I'm nervous applying this change more broadly across the site, so for now I've scoped it to only share pages. Verified Artist share pages now load zoomed out on an iPhone.

Before: After:
image uploaded from ios image uploaded from ios 1

Copy link

@jeremydstone jeremydstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@joshlory joshlory merged commit a3bb3ea into staging Jul 5, 2017
@joshlory joshlory deleted the sharing-mobile-viewport branch July 5, 2017 20:35
Copy link
Member

@breville breville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants