auto-commit new video thumbnails generated in bin/cron/fetch_external_resources #16313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When videos are added to videos.csv, a cronjob on staging updates the database and the local filesystem to reflect the changes. An engineer must then scoop the images under
dashboard/public/c/video_thumbnails/
or else videos and thumbnails will be mismatched. In the best case, a failure to do this leads to a failed DTT. In the worst case, if none of the mismatched thumbnails are covered by tests, a wrong video thumbnail could make it to production.This PR modifies the cronjob to commit and push the new video thumbnails to
origin/staging
, minimizing the chances of a DTT which includes changes tovideos.csv
without the corresponding changes todashboard/public/c/video_thumbnails/
.verification
initial conditions:
cronjob run:
video thumbnails were committed and pushed:
non-video files in the git index were not committed: