Disable script and course dropdown caches on levelbuilder #16326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/code-dot-org/code-dot-org/blob/staging/dashboard/app/models/script.rb#L200 Shouldn't we not be caching at all on LB already? (We have the same code for course). |
|
This is for a separate cache that lives under Pegasus's |
Bjvanminnen
reviewed
Jul 10, 2017
| select(:id, :name). | ||
| all. | ||
| # Only return courses we've whitelisted in ScriptConstants | ||
| select {|course| ScriptConstants.script_in_category?(:full_course, course[:name])}. | ||
| map {|course| assignable_info(course)} | ||
| @@course_cache[course_cache_key] = courses unless rack_env(:levelbuilder) | ||
| courses |
There was a problem hiding this comment.
Presumably we could write to the cache regardless (but only read from cache if !levelbuilder) if we wanted to minimize how different things are.
Bjvanminnen
approved these changes
Jul 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently create or deleted scripts don't show up in (or disappear from) the teacher dashboard dropdown because of the cache, which has caused confusion for levelbuilders in the past. I'm guessing we would have the same problem while creating and deleting courses, though that wouldn't come up very often.
We could instead clear the caches when you create or delete a script or course, but I'm not sure how easy it is to muck with pegasus state from dashboard code like that.