Student homepage: only one UI tip should show #16368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that there is a student homepage, make sure the existing UI tools only show for teachers. Students will get a single UI tip when they click the upper-left logo.
|
cc @tanyaparker |
Bjvanminnen
reviewed
Jul 12, 2017
| {type: "triggered", position: {top: 80, right: 15}, text: i18n.homepageUiTipAlreadyHome(), triggerId: "logo_home_link", arrowDirection: "up_corner"} | ||
| ]} | ||
| /> | ||
| )} |
There was a problem hiding this comment.
I'd split line 54 into multiple lines, as it's quite long.
Also, as an FYI the parens on lines 50/57 are unnecessary (though fine).
There was a problem hiding this comment.
Yeah I just started putting those parens in as a habit because I was bitten by needing them when there was an II in the expression.
Bjvanminnen
approved these changes
Jul 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that there is a student homepage, make sure the existing UI tools only show for teachers. Students will get a single UI tip when they click the upper-left logo.