Courses: expanded list of recent courses needs spacers #16369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @tanyaparker |
Bjvanminnen
reviewed
Jul 12, 2017
| link={course.link} | ||
| isRtl={isRtl} | ||
| /> | ||
| {(index % 2 === 0) && <div style={styles.spacer}>.</div>} |
There was a problem hiding this comment.
Is this spacer going to be a common thing used throughout our code? I wonder if we should just have a Spacer component?
Would also be nice to include a screenshot.
There was a problem hiding this comment.
Sorry, screenshots on my machine were broken yesterday :)
I think we'll switch over to using flexbox for components such as these because it can do justified layout which solves the need for these horizontal spacers.
Bjvanminnen
approved these changes
Jul 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.