Call API to import a Google Classroom on "Import Section" click #16385
Conversation
|
|
||
| export const sectionShape = PropTypes.shape({ | ||
| id: PropTypes.number.isRequired, | ||
| name: PropTypes.string.isRequired, | ||
| // Though we validate valid login types here, the server actually owns the | ||
| // canonical list, and passes us the list of valid login types. | ||
| loginType: PropTypes.oneOf(['word', 'email', 'picture']).isRequired, | ||
| loginType: PropTypes.oneOf(Object.keys(SectionLoginType)).isRequired, |
|
|
||
| $.getJSON('/dashboardapi/import_google_classroom', { courseId }).then(() => { | ||
| this.setState({rosterDialogOpen: false}); | ||
| this.setState({sectionsLoaded: false}); |
There was a problem hiding this comment.
These two can be combined into one line (i.e. you can set multiple state field in a single call to setState)
| $.getJSON("/v2/sections/").done(results => { | ||
| this.props.setSections(results, true); | ||
| this.setState({sectionsLoaded: true}); | ||
| }); |
There was a problem hiding this comment.
Both of these APIs set sectionsLoaded. If the call to /v2/sections finishes first, we end up with sectionsLoaded = true. If import_google_classroom finishes first, we end up with sectionsLoaded = false
There was a problem hiding this comment.
Not sure I follow. The JSON calls are nested, so the /v2/sections request won't start until after the first request resolves.
There was a problem hiding this comment.
My bad. Didn't realize they were nested.
| @@ -18,7 +18,7 @@ export const setValidAssignments = (validCourses, validScripts) => ({ | |||
| validCourses, | |||
| validScripts | |||
| }); | |||
| export const setSections = sections => ({ type: SET_SECTIONS, sections }); | |||
| export const setSections = (sections, reset = false) => ({ type: SET_SECTIONS, sections, reset }); | |||
There was a problem hiding this comment.
Would like to see a comment somewhere about what reset means
|
Would like to see some tests. |
joshlory
force-pushed
the
import-google-classroom-next
branch
from
f1bec8e
to
2674059
Compare
| return { | ||
| ...state, | ||
| sectionIds: state.sectionIds.concat(sections.map(section => section.id)), | ||
| sectionIds: prevSectionIds.concat(sections.map(section => section.id)), |
There was a problem hiding this comment.
might be good to get some test coverage of this reset behavior in teacherSectionsReduxTest.js
|
Was hoping to still see some test coverage of reset behavior in teacherSectionsRedux. |
|
Ok, I'll create a follow up PR. |
Connects the "Import Section" button to
ApiController#import_google_classroom. Follow up to PR #16342.