Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit build step with the same status as rake build #16396

Merged
merged 1 commit into from Jul 13, 2017
Merged

Exit build step with the same status as rake build #16396

merged 1 commit into from Jul 13, 2017

Conversation

balderdash
Copy link
Contributor

@balderdash balderdash commented Jul 13, 2017 •
edited

This step has been silent about failures since my previous change (e.g. https://circleci.com/gh/code-dot-org/code-dot-org/42400), which is very confusing.

@balderdash balderdash requested a review from joshlory July 13, 2017 19:06
joshlory
joshlory approved these changes Jul 13, 2017
View reviewed changes
Copy link
Contributor

@joshlory joshlory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@balderdash balderdash merged commit 41baf66 into staging Jul 13, 2017
@balderdash balderdash deleted the fail-build branch July 18, 2017 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshlory joshlory joshlory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@balderdash @joshlory