Courses: show extra content for students in en #16398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanyaparker
approved these changes
Jul 13, 2017
Bjvanminnen
reviewed
Jul 13, 2017
| @@ -60,6 +60,8 @@ const Courses = React.createClass({ | |||
| $('#user_hero').appendTo(ReactDOM.findDOMNode(this.refs.userHero)).show(); | |||
| $('.all-courses').appendTo(ReactDOM.findDOMNode(this.refs.allCourses)).show(); | |||
| $('.hour-of-code-courses-first-row').appendTo(ReactDOM.findDOMNode(this.refs.hocCoursesFirstRow)).show(); | |||
| $('.csf-courses').appendTo(ReactDOM.findDOMNode(this.refs.csfCourses)).show(); | |||
| $('.tools-courses').appendTo(ReactDOM.findDOMNode(this.refs.toolsCourses)).show(); | |||
There was a problem hiding this comment.
Is the intention that all/most of these eventually end up in React?
Bjvanminnen
approved these changes
Jul 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Students on /courses in en should see blocks for CSF, Tools, Hour of Code (1 row only, with new header).
This is a surgical fix to unblock deploy. It's obviously due for a refactor, particularly in the way we're yanking out parts of the
all_coursesHAML while leaving that file still operational.