Progress diamonds #16418
Merged
Progress diamonds #16418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bjvanminnen
force-pushed
the
progressDiamonds
branch
from
333802f
to
667a5b3
Compare
islemaster
approved these changes
Jul 14, 2017
| style={{ | ||
| display: 'inline-block', | ||
| width: (smallBubble ? SMALL_DOT_SIZE : DOT_SIZE) + | ||
| 2 * styles.main.borderWidth + 2 * 2, |
There was a problem hiding this comment.
At the very least, should the last 2 * 2 here be simplified to 4?
There was a problem hiding this comment.
I was trying to make this less magical (it's essentially meant to be 2px of margin on each side). Without a comment though, it might not be any less magical. Will address in a future PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.google.com/document/d/11eQJ30FW48pFe7Eq7OGOr9fiQ5jj3EpJX79mrkcm5v4/edit?pli=1#heading=h.qsf3wy9ba0ro
This PR makes it so that "concept" levels will get diamonds instead of of circles. This is true on the overview page:
It is also true in the header, for both the current level and other levels in the stage (which will have small diamonds).
The next step will be changing the colors on these.